Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equation 8 and 9 #20

Open
ramess101 opened this issue Dec 19, 2018 · 3 comments
Open

Equation 8 and 9 #20

ramess101 opened this issue Dec 19, 2018 · 3 comments

Comments

@ramess101
Copy link
Owner

@mrshirts @jpotoff

Michael expressed a concern that I have had for a while but failed to mention. In the manuscript we refer to Pr_i(N,U) as the probability, when really I believe it is the number of snapshots that fall in the histogram bin N,U.

Here are the equations and text as they were found previously:

image

I think we want this to read K_snaps,i(N,U), since this would more clearly denote a histogram "count" rather than a probability.

Does this look correct?

image
image

@ramess101
Copy link
Owner Author

@mrshirts @jpotoff

This is how Pana described the equations. Notice that I changed f_i(N,E) to Pr_i(N,U), because he described it as a probability. But his description that K_i=sum over f_i makes it seem like this is really the histogram count.

image

image

@ramess101
Copy link
Owner Author

@mrshirts @jpotoff

When I looked through the actual histogram reweighting code, it appears that I do not use the normalized histogram probability, rather I use the histogram "count." It is possible that the probability can be used in a different format, but the way the equations are actually written I think it should be the count.

@mrshirts
Copy link
Contributor

The K_snaps,i(N,E) formalism looks correct to me. That's what reduces to the sum over observations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants