Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Fixed issue where paths with URL encoded characters were being passed… #155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drb
Copy link

@drb drb commented Aug 12, 2015

… to the filesystem when attempting to load a file using fetchLocalFileAsync(), causing an exception to be raised.

Using a path like path/to a file/file.raml would be passed to the method as path/to%20a%20file/file.raml which would raise an exception from the call to fs.readFile. A simple patch has been added to normalize urlencoded strings before being passed into this method.

… to the filesystem when attempting to load a file using fetchLocalFileAsync(), causing an exception to be raised.
@dmartinezg
Copy link

Can you add a test to verify the regression?

@dmartinezg
Copy link

Also just to double, check, have you signed the Contributor agreement?

@drb
Copy link
Author

drb commented Aug 12, 2015

I'll add a test ASAP. Contrib agreement is signed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants