Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shinyRenderWidget: Add support for caching #391

Merged
merged 3 commits into from
Nov 13, 2020

Conversation

wch
Copy link
Contributor

@wch wch commented Nov 5, 2020

Switching from exprToFunction to installExprFunction will make it possible for htmlwidgets to benefit from Shiny's new bindCache and bindEvent functions.

It also removes a check for the existence of createRenderFunction, which was added in Shiny 1.1.0 (and was released 2018-05).

@wch wch changed the title shinyRenderWidget: use installExprFunction shinyRenderWidget: Add support for caching Nov 5, 2020
@cpsievert cpsievert self-requested a review November 13, 2020 16:59
@cpsievert cpsievert added this to the CRAN 1.5.3 milestone Nov 13, 2020
@jcheng5 jcheng5 merged commit 530cfbb into ramnathv:master Nov 13, 2020
@wch wch deleted the update-renderwidget branch November 13, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants