Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing null instance checks. Initialize _follow_spring_arm parameters upon instantiation #258

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Adding missing null instance checks. Initialize _follow_spring_arm parameters upon instantiation #258

merged 1 commit into from
Apr 26, 2024

Conversation

ZenithStar
Copy link
Contributor

Resolves #257

@ZenithStar ZenithStar changed the title Adding missing null instance checks. Initialize _follow_spring_arm paameters upon instantiation Adding missing null instance checks. Initialize _follow_spring_arm parameters upon instantiation Apr 26, 2024
ramokz
ramokz approved these changes Apr 26, 2024
View reviewed changes
Copy link
Owner

@ramokz ramokz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instance validators makes a lot of sense.

Still want to see if the SpringArm3D property assignments can be moved away from the _process and into the_ready() function, as that keeps a bit cleaner, so this makes for a good start for that as well.

@ramokz ramokz merged commit 7897458 into ramokz:main Apr 26, 2024
@ramokz
Copy link
Owner

ramokz commented Apr 26, 2024

Thanks for adding this 🎉

@ZenithStar ZenithStar deleted the 0.7-3rdperson-bugfix branch April 26, 2024 10:19
@ZenithStar ZenithStar mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramokz ramokz ramokz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FollowMode.THIRD_PERSON attempts to set _follow_spring_arm parameters even if _follow_spring_arm is null
2 participants
@ZenithStar @ramokz