Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring part 1 #12

Merged
merged 1 commit into from
Jul 16, 2017
Merged

Refactoring part 1 #12

merged 1 commit into from
Jul 16, 2017

Conversation

lipanski
Copy link
Contributor

  • favour defaults
  • for everything else: builder pattern
  • make some struct fields private
  • relax constraints on arguments by allowing Into<String> and AsRef<str> where possible

@lipanski
Refactor parts of the interface by using the builder pattern, hiding …
a8ca2d8 
…some public struct fields, relaxing constraints on arguments, favouring defaults.
@lipanski lipanski merged commit 08b711c into master Jul 16, 2017
@lipanski lipanski deleted the builder_pattern branch July 16, 2017 15:31
@lipanski lipanski mentioned this pull request Jul 16, 2017
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lipanski