Migrate Storylines Editor to Vue3 #242
Conversation
dnlnashed
force-pushed
the
vue3-refactor
branch
2 times, most recently
from
2158b0e
to
29fb1bd
Compare
…, router + app initialization
dnlnashed
force-pushed
the
vue3-refactor
branch
from
29fb1bd
to
0e1bbfb
Compare
There was a problem hiding this comment.
Things all look to be working correctly when I poke around the demo
Reviewed 33 of 49 files at r1, 1 of 5 files at r2, 2 of 9 files at r3, 4 of 6 files at r4, 11 of 11 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dnlnashed)
There was a problem hiding this comment.
Briefly looked over all of the code and it looks good to me! I also tested loading existing products and creating a new one and that all seems good as well.
I did notice one small thing: when you preview a product, it's not displaying the logo at the top. I'll log a new issue for this though.
Reviewed 33 of 49 files at r1, 1 of 5 files at r2, 2 of 9 files at r3, 4 of 6 files at r4, 11 of 11 files at r5, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 33 of 49 files at r1, 1 of 5 files at r2, 2 of 9 files at r3, 4 of 6 files at r4, 11 of 11 files at r5, all commit messages.
Reviewable status:
There was a problem hiding this comment.
lgtm - the build and tooling might benefit from future updates, there have been quite a few changes with v3 and even changes during the v3 lifecycle. For now though this is totally fine.
Reviewed 1 of 49 files at r1, 1 of 9 files at r3, 1 of 11 files at r5, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 33 of 49 files at r1, 1 of 5 files at r2, 2 of 9 files at r3, 4 of 6 files at r4, 11 of 11 files at r5, all commit messages.
Reviewable status:
Related Issues: #192 #216 #237
Done together with @yileifeng
Changes
vue2-modalswas replaced withvue-final-modalramp-storylinesVue3 plugin from https://www.npmjs.com/package/ramp-storylinesFuture Tasks
This change is