Make EXIF data displayed configurable #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rampatra
reviewed
Apr 24, 2023
rampatra
reviewed
Apr 24, 2023
|
|
||
| # Config which exif data to display | ||
| # Tag is the actual exif tag, icon is a fontawesome icon. Use JSON notation without line breaks | ||
| exif_display: '[{"tag": "Model", "icon": "camera-retro"}, {"tag": "FNumber", "icon": "dot-circle-o"}, {"tag": "ExposureTime", "icon": "clock-o"}, {"tag": "ISOSpeedRatings", "icon": "info-circle"}]' |
There was a problem hiding this comment.
Maybe a better name would be exif_tags instead of exif_display.
rampatra
reviewed
Apr 24, 2023
| @@ -307,46 +307,18 @@ | |||
| }); | |||
|
|
|||
| function getExifDataMarkup(img) { | |||
| var exif = fetchExifData(img); | |||
| var exif_display = $('#main').data('exif-display'); | |||
rampatra
reviewed
Apr 24, 2023
| @@ -16,7 +16,7 @@ <h1><a href="index.html"><strong>{{ site.header.title }}</strong> {{ site.header | |||
| </header> | |||
|
|
|||
| <!-- Main --> | |||
| <div id="main"> | |||
| <div id="main" data-exif-display='{{ site.exif_display }}'> | |||
|
If you (after 3,5 years of no comment) still care about this PR feel free to copy the provided code and merge it yourself. This PR can be considered as MIT-licensed, thus do what you want with the code. |
|
I am not sure how but I missed this PR. I didn't get an email about this PR in my inbox. Anyway, thanks for your comment, I'll add it to the repo. Thanks again for your time. |
|
Changes added to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11 via EXIF UserComment and Closes #23
I only tested this with my own site, but it works well enough over there.
I didn't really test anything but the default so it might break if one were to put loads of stuff into the exif-data footer and/or has an exif user-comment that is pretty long.
People will just have to figure it out I guess.