This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
Fix config.registry.auth_model missing properties crashing the server on startup #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies declared before itself
postatum
added a commit
that referenced
this pull request
Nov 18, 2015
Fix config.registry.auth_model missing properties crashing the server on startup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixed: If the resource designated as the auth model is declared after a resource that depends on it in the main raml file, then config.registry.auth_model is not properly populated and the server will crash on startup.
Fix: Added an additional check when the model already exists to see if the model is designated as the auth model.
I also added a test case for this situation.