Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support uuid6 if it's available #18

Closed
wants to merge 1 commit into from

Conversation

sunkan
Copy link
Contributor

@sunkan sunkan commented Sep 24, 2021

Description

Support generating uuid v6 if ramsey/uuid have it available

Motivation and context

I expected the cli version of the library to support all uuid version on the main class

How has this been tested?

Full coverage by unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@sunkan sunkan requested a review from ramsey as a code owner September 24, 2021 07:55
ramsey pushed a commit that referenced this pull request Dec 21, 2022
@ramsey
Copy link
Owner

ramsey commented Dec 21, 2022

Thank you for contributing! 🎉

I've committed this in b77306d. Better late than never. ;-)

@ramsey ramsey closed this Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants