Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix financials tables #1128

Merged
merged 24 commits into from
Oct 28, 2022
Merged

Fix financials tables #1128

merged 24 commits into from
Oct 28, 2022

Conversation

ValueRaider
Copy link
Collaborator

@ValueRaider ValueRaider commented Oct 28, 2022 •
edited
Loading

Fixes financials tables to match what's on website. This PR is redoing #1090 except with MultiIndex disabled, that requires more thought.

Also adds new properties with more analysts' work:

Ticker.recommendations_summary
Ticker.analyst_price_target
Ticker.revenue_forecasts
Ticker.earnings_forecasts
Ticker.earnings_trend

Fixes: #1056 #1052 #1044 #1043 #1011 #1004 #1001 #913

Credit to @git-shogg

git-shogg and others added 24 commits July 7, 2021 18:50
@git-shogg
Updated the utils get_json function to standardize the return. This w…
883b7f0 
…ill enable us to see other store types from the base.py file.
@git-shogg
Added some functions to enable us to grab key details from the analys…
91f4891 
…is section of yahoo finance: current_recommendations, revenue_forecasts and earnings_forecasts.
@git-shogg
Updated README to include additional functions.
da2672f
@git-shogg
Updated to include analyst price target forecasts.
cb31036
@git-shogg
Added self._income_statement, once happy this new dataframe should re…
a1769e4 
…place self._financials. Further work required to understand if there is the opportunity to also do this for balance sheet and cf statement.
@git-shogg
Finished updating all of the required updates.
c3da55f
@git-shogg
Merge https://github.com/ranaroussi/yfinance into main
4774485
@git-shogg
Updated to align with the yfinance upstream main.
81a0a4e
@git-shogg
Potential issues flagged by CodeFactor updated. Believe that the warn…
87dc9fb 
…ings with regards to "statement seems to have no effect" is because the import on this python file is yfinance (master version 1.63).
@git-shogg
Updated to resolve Travis CI Build Fail.
e7c55bb
@git-shogg
Updated base with some exceptions and utils.
7a395c3
@git-shogg
Updated to ensure .info is brought in correctly.
3f23c06
@ValueRaider
Manually merge pull request #776 - Fix & enhance annual financials
c80bfc0
@ValueRaider
Add new time-series functions and compare against new scraping
34e1b2f
@git-shogg
Remediated missing annual table line items flagged by @ValueRaider.
6c4da51
@git-shogg
Merged (refactored). Quarterlies updates. Multi-Index Inlcluded.
d65391b
@git-shogg
Functions to minimize get_fundamentals. _DEV tests removed.
3b8114c
@ValueRaider
Merge pull request #776 from git-shogg/main
68b8671 
Enhanced the detail of the annual financial statements and added ability to check the "Analysis" url.
@ValueRaider
Refactor properly ; Rename some new properties
6e96a1a
@ValueRaider
Fix financials placeholders
730afda
@ValueRaider
Port in @git-shogg fix, & fix typos
053e0b9
@ValueRaider
Financials - reorder rows to match website, disable MultiIndex
e29df56
@ValueRaider
Revert version bump
9e529f3
@ValueRaider
Merge branch 'dev' into fix/financials-data
e83cc74
@ValueRaider ValueRaider merged commit bcd6e5b into dev Oct 28, 2022
@ValueRaider
Copy link
Collaborator Author

@fredrik-corneliusson FYI this is likely to trigger more IDE warnings/errors

@ValueRaider ValueRaider mentioned this pull request Oct 28, 2022
Closed
@fredrik-corneliusson
Copy link
Contributor

Have created #1130 with the needed formatting updates.

@ValueRaider ValueRaider deleted the fix/financials-data branch October 31, 2022 21:15
@ValueRaider ValueRaider mentioned this pull request Nov 11, 2022
Merged
@ValueRaider ValueRaider mentioned this pull request Dec 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValueRaider @fredrik-corneliusson @git-shogg