Create a mount script instead of editing /etc/fstab #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mook-as
previously approved these changes
Jun 6, 2023
| sed -i '/#LIMA-START/,/#LIMA-END/d' /etc/fstab | ||
| echo "#LIMA-START" >> /etc/fstab | ||
| awk -f- "${LIMA_CIDATA_MNT}"/user-data <<'EOF' >> /etc/fstab | ||
| MOUNT_SCRIPT=/etc/lima-mounts |
There was a problem hiding this comment.
Hmm, I'm not sure (as a script) it should live in /etc. But I guess that doesn't hurt? It's not as if /etc/init.d/ isn't full of scripts…
There was a problem hiding this comment.
I didn't know where else to put it. And I wanted to keep a record of it, which is why I didn't just pipe it into the shell.
| @@ -49,15 +49,17 @@ awk -f- "${LIMA_CIDATA_MNT}"/user-data <<'EOF' >> /etc/fstab | |||
| flag = 0 | |||
| } | |||
| flag { | |||
There was a problem hiding this comment.
This bit can use more documentation.
Given a line like:
- [mount1, /tmp/rancher-desktop, 9p, "rw,trans=virtio,version=9p2000.L,msize=131072,cache=mmap,nofail", "0", "0"]| @@ -49,15 +49,17 @@ awk -f- "${LIMA_CIDATA_MNT}"/user-data <<'EOF' >> /etc/fstab | |||
| flag = 0 | |||
| } | |||
| flag { | |||
| # Use a pattern unlikely to appear in a filename. "\0" unfortunately doesn't work. | |||
| FS = "<;><><;>" | |||
| sub(/^ *- \[/, "") | |||
| @@ -49,15 +49,17 @@ awk -f- "${LIMA_CIDATA_MNT}"/user-data <<'EOF' >> /etc/fstab | |||
| flag = 0 | |||
| } | |||
| flag { | |||
| # Use a pattern unlikely to appear in a filename. "\0" unfortunately doesn't work. | |||
| FS = "<;><><;>" | |||
| sub(/^ *- \[/, "") | |||
| sub(/"?\] *$/, "") | |||
There was a problem hiding this comment.
This strips the ] suffix, possibly with a " in front…
| sub(/^ *- \[/, "") | ||
| sub(/"?\] *$/, "") | ||
| gsub("\"?, \"?", "\t") | ||
| print $0 | ||
| gsub("\"?, \"?", FS) |
There was a problem hiding this comment.
And this… replaces ", " with the field separator? So it's a very limited YAML parse.
This enables support for mount points that include spaces. `/etc/fstab` normally supports encoding special characters in filenames using octal constants (like "\040` for a space), but that doesn't work on Alpine. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
mook-as
approved these changes
Jun 6, 2023
This was referenced Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables support for mount points that include spaces.
/etc/fstabnormally supports encoding special characters in filenames using octal constants (like "\040` for a space), but that doesn't work on Alpine.