Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-v2.8] rancher-monitoring 103.1.0-rc1+up45.31.1 update #3609

Merged
merged 2 commits into from
Apr 16, 2024
Merged

[dev-v2.8] rancher-monitoring 103.1.0-rc1+up45.31.1 update #3609

merged 2 commits into from
Apr 16, 2024

Conversation

ericpromislow
Copy link
Contributor

@ericpromislow ericpromislow commented Mar 12, 2024 •
edited
Loading

Issue: #44606

Problem

Bump the chart to move prometheus dependency from 2.42. to 2.45 (the latest LTS version)

Backporting considerations

This is the backport version of Issue #44605, which made the same change on dev-v2.9

@ericpromislow ericpromislow requested review from a team as code owners March 12, 2024 21:22
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

adamkpickering
adamkpickering approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@adamkpickering adamkpickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just perform the validation steps above and this should be good to go.

alexandreLamarre
alexandreLamarre reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@alexandreLamarre alexandreLamarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshmeranda Do we want to wait until after 2.8.3 to merge this?

@joshmeranda
Copy link
Contributor

@alexandreLamarre we can merge now

@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

lucasmlp
lucasmlp previously requested changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@lucasmlp lucasmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the monitoring package to release.yaml so that the CI will pass

@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@ericpromislow ericpromislow marked this pull request as draft March 18, 2024 20:34
@prachidamle
Copy link
Member

This PR is for the issue rancher/rancher#44606

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@ericpromislow ericpromislow marked this pull request as ready for review April 4, 2024 19:39
@ericpromislow ericpromislow dismissed lucasmlp’s stale review April 4, 2024 19:49

Adding the rancher-monitoring-* entries to release.yaml was done in the parent branch

@ericpromislow ericpromislow requested review from adamkpickering and removed request for adamkpickering April 4, 2024 19:50
nicholasSUSE
nicholasSUSE previously requested changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@nicholasSUSE nicholasSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts.

Hello, we have improved the Charts documentation regarding Pull Request Rules.

Please take a look at it before making any new Pull Requests.
We are still approving Pull Requests and starting to inform all teams, soon we will require the standard in the documentation.

https://github.com/rancher/charts?tab=readme-ov-file#pull-request-rules

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@ericpromislow ericpromislow changed the title [dev-v2.8] Bump rancher-monitor to bump dependency prometheus to 2.45 [dev-v2.8] rancher-monitoring 103.1.0-rc1+up45.31.1 update Apr 11, 2024
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

lucasmlp
lucasmlp approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@lucasmlp lucasmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ericpromislow ericpromislow dismissed nicholasSUSE’s stale review April 16, 2024 17:46

Changes have been done

@ericpromislow ericpromislow merged commit 3b8cbe7 into rancher:dev-v2.8 Apr 16, 2024
6 checks passed
@ericpromislow ericpromislow deleted the 44606-bump-prometheus-to-2.45 branch April 16, 2024 17:48
@ericpromislow ericpromislow mentioned this pull request Apr 16, 2024
Closed
lucasmlp pushed a commit that referenced this pull request May 8, 2024
@ericpromislow @lucasmlp
[dev-v2.8] rancher-monitoring 103.1.0-rc1+up45.31.1 update (#3609)
28f98b7
@lucasmlp lucasmlp mentioned this pull request May 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmlp lucasmlp lucasmlp approved these changes

@alexandreLamarre alexandreLamarre alexandreLamarre approved these changes

@joshmeranda joshmeranda Awaiting requested review from joshmeranda

@adamkpickering adamkpickering Awaiting requested review from adamkpickering

@nicholasSUSE nicholasSUSE Awaiting requested review from nicholasSUSE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ericpromislow @joshmeranda @prachidamle @adamkpickering @lucasmlp @alexandreLamarre @nicholasSUSE