-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-v2.8] rancher-monitoring 103.1.0-rc1+up45.31.1 update #3609
[dev-v2.8] rancher-monitoring 103.1.0-rc1+up45.31.1 update #3609
Conversation
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just perform the validation steps above and this should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshmeranda Do we want to wait until after 2.8.3 to merge this?
@alexandreLamarre we can merge now |
72ce421
to
0efd66a
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add the monitoring package to release.yaml
so that the CI will pass
0efd66a
to
06802e1
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
This PR is for the issue rancher/rancher#44606 |
06802e1
to
ce97dcd
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
Adding the rancher-monitoring-*
entries to release.yaml was done in the parent branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts.
Hello, we have improved the Charts documentation regarding Pull Request Rules.
Please take a look at it before making any new Pull Requests.
We are still approving Pull Requests and starting to inform all teams, soon we will require the standard in the documentation.
https://github.com/rancher/charts?tab=readme-ov-file#pull-request-rules
ce97dcd
to
b9919e5
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
b9919e5
to
e94ce9f
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
e94ce9f
to
a65cb98
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
a65cb98
to
a4f366c
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
a4f366c
to
9c933ff
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
9c933ff
to
48c531c
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Issue: #44606
Problem
Bump the chart to move prometheus dependency from 2.42. to 2.45 (the latest LTS version)
Backporting considerations
This is the backport version of Issue #44605, which made the same change on dev-v2.9