Remove changing value passed from cli #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dramich
reviewed
Apr 7, 2020
brendarearden
force-pushed
the
add-helmversion-flag
branch
from
efd8c3b
to
70c00a4
Compare
brendarearden
force-pushed
the
add-helmversion-flag
branch
from
70c00a4
to
5f21722
Compare
dramich
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Manipulating the value to an expected value when can be confusing because the value submitted is not what appears on the object
Solution
Use value from cli as helm version instead of changing it
Issue
rancher/rancher#25262