-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go version and dependencies bump to 1.19 #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few nits that I'd be ok merging without updates if needed.
go.mod
Outdated
|
||
replace github.com/coreos/bbolt => go.etcd.io/bbolt v1.3.6 | ||
|
||
replace google.golang.org/grpc => google.golang.org/grpc v1.26.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we organize deps in replace directive together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Dockerfile.dapper
Outdated
rm -f /bin/sh && ln -s /bin/bash /bin/sh | ||
RUN zypper -n install git docker vim less file curl wget | ||
#RUN go install golang.org/x/lint/golint@latest && go install golang.org/x/tools/cmd/goimports@latest | ||
#RUN if [[ "${ARCH}" == "amd64" ]]; then \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need the commented parts or can be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. Thanks for spotting this.
Signed-off-by: Guilherme Macedo <guilherme.macedo@suse.com>
@kinarashah feedback addressed. Can you please review again? |
@macedogm Thank you, approved! |
Signed-off-by: Guilherme Macedo guilherme.macedo@suse.com