Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Cloud Credentials: Pressing enter navigates to Select Existing instead of submitting form #7112

Closed
rak-phillip opened this issue Oct 6, 2022 · 3 comments · Fixed by #7267
Assignees
Milestone

Comments

@rak-phillip
Copy link
Member

rak-phillip commented Oct 6, 2022

Setup

  • Rancher version: 78c7ac0 (latest build from master at time of writing)
  • Browser type & version: Firefox 106.0b8

Describe the bug

Pressing enter on the Create Cloud Credentials page navigates to Select Existing instead of submitting the form.

To Reproduce

  1. Navigate to Clusters => Create
  2. Toggle RKE2/K3s so that it's on
  3. Select Digital Ocean
  4. Enter a Credential Name and an Access Token
  5. Press Enter to submit the form

Result

The page for selecting existing credentials is shown.

Expected Result

I expect the cloud credential to be created and to navigate to the cluster creation form.

Additional context

The Continue button is the primary action on this form and I expect this to be action that will be taken when pressing enter. Select Existing is secondary and I would expect that I would need to select this option in order to use it.

@slickwarren
Copy link
Contributor

seeing this on v2.6.9-rc3 as well with any provider (linode, aws, etc.)

@slickwarren slickwarren modified the milestones: v2.6.9, v2.7.0 Oct 13, 2022
@slickwarren slickwarren self-assigned this Oct 13, 2022
@nwmac nwmac modified the milestones: v2.7.0, v2.7.1 Oct 14, 2022
@nwmac
Copy link
Member

nwmac commented Oct 19, 2022

Note: this is the case when you have no cloud credentials - when you hit create, you are taken to the screen to create a new credential - pressing 'continue' goes to the list and does not continue with cluster creation.

@slickwarren
Copy link
Contributor

tested on v2.7-head (d1249b5):

  • create cloud credential from cluster -> create page -- pass (keyboard enter seems to be disabled)
  • create cloud credential from cloud credential -> create page -- pass (keyboard enter seems to be disabled)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants