Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workload): clean up some labels,matchLabels and annotations when cloning a job #10201

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

ly5156
Copy link
Contributor

@ly5156 ly5156 commented Dec 25, 2023

Summary

Fixes #10200

Occurred changes and/or fixed issues

  1. remove labels: batch.kubernetes.io/controller-uid, batch.kubernetes.io/job-name, controller-uid, job-name
  2. remove annotation: batch.kubernetes.io/job-tracking

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@nwmac
Copy link
Member

nwmac commented Apr 23, 2024

@ly5156 This needs a rebase with master so that all of the e2e suites are run

@ly5156
Copy link
Contributor Author

ly5156 commented Apr 24, 2024

@ly5156 This needs a rebase with master so that all of the e2e suites are run

@nwmac
I've rebased the master branch code.

@nwmac nwmac merged commit ff1c90d into rancher:master Apr 30, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save error when cloning a job
3 participants