-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the logging chart to use tabs for each provider #1048
Conversation
|
@codyrancher @vincent99 after talking with @paynejacob, it seems the provider configuration should be moved out of the helm deployment and into individual CRD pages as helm upgrades will override any changes in the CRDs. But the work in these tickets should be pushed to the individual CRD pages for cluster outputs. |
Alright well that eliminates the need for enabled flags altogether.. @codyrancher can you update this PR to show whatever options are still supposed to be there on install of the chart. You can leave the individual provider config code orphaned for future crd work.. |
Yeah. I'll go ahead and update once I find out what the options are going to be. |
@codyrancher I think the options are being simplified a lot, but @paynejacob should provide input on what is expected. |
I'm just going to orphan this PR and dot he work elsewhere. |
Adapt console window to the screen
…vester-v1.2/pr-1048 Adapt console window to the screen (backport rancher#1048)
#1027