Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the logging chart to use tabs for each provider #1048

Closed
wants to merge 1 commit into from

Conversation

codyrancher
Copy link
Contributor

@vincent99
Copy link
Contributor

  • The dropdown for disabled/enabled on each driver and some other bool fields seems sort of odd vs a [ ] Enabled checkbox.
  • Since there's nothing else in the tab I'd probably go with the options (host, port, etc) are always shown, but disabled if !enabled
  • Host / Scheme / Port should go in logical order, and possibly as one row... [scheme http]://[host foo.com]:[port 443]

@codyrancher
Copy link
Contributor Author

  • The dropdown for disabled/enabled on each driver and some other bool fields seems sort of odd vs a [ ] Enabled checkbox.

To me this looks pretty odd. I'm fine to make the change but here's a screenshot. Let me know if you'd still like this change.
Screen Shot 2020-08-18 at 2 27 55 PM

  • Since there's nothing else in the tab I'd probably go with the options (host, port, etc) are always shown, but disabled if !enabled

That's actually what I originally did but our enabled vs disabled doesn't look very distinct to me and the show vs hide made it very evident that you needed to enable things first. But I'll make the change if that's what you'd like.
Screen Shot 2020-08-18 at 2 25 30 PM
Screen Shot 2020-08-18 at 2 35 45 PM

  • Host / Scheme / Port should go in logical order, and possibly as one row... [scheme http]://[host foo.com]:[port 443]

Done. Definitely looks better.
Screen Shot 2020-08-18 at 2 33 18 PM

@deniseschannon
Copy link

@codyrancher @vincent99 after talking with @paynejacob, it seems the provider configuration should be moved out of the helm deployment and into individual CRD pages as helm upgrades will override any changes in the CRDs. But the work in these tickets should be pushed to the individual CRD pages for cluster outputs.

@vincent99
Copy link
Contributor

Alright well that eliminates the need for enabled flags altogether.. @codyrancher can you update this PR to show whatever options are still supposed to be there on install of the chart. You can leave the individual provider config code orphaned for future crd work..

@codyrancher
Copy link
Contributor Author

Yeah. I'll go ahead and update once I find out what the options are going to be.

@deniseschannon
Copy link

@codyrancher I think the options are being simplified a lot, but @paynejacob should provide input on what is expected.

@codyrancher
Copy link
Contributor Author

I'm just going to orphan this PR and dot he work elsewhere.

@codyrancher codyrancher deleted the tabbed-logging branch December 1, 2020 15:45
torchiaf added a commit to torchiaf/dashboard that referenced this pull request Jun 25, 2024
torchiaf added a commit to torchiaf/dashboard that referenced this pull request Oct 28, 2024
…vester-v1.2/pr-1048

Adapt console window to the screen (backport rancher#1048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants