Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automation: Backport e2e tests to 2.8 #10552

Merged
merged 28 commits into from
Apr 3, 2024

Conversation

yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Mar 4, 2024

Summary

Fixes # rancher/qa-tasks#1189

Technical notes summary

Backport the provisioning e2e tests (and their dependencies) to 2.8

Update: I've also added the changes to support running e2e tests in parallel in this backport to reduce the time it takes for the test run to complete
#9887

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@izaac
Copy link
Contributor

izaac commented Mar 5, 2024

Thanks for consolidating all this @yonasberhe23, as discussed offline these are existing tests recently merged on latest but I'll defer to @richard-cox the code implementation to make it work on the 2.8 branch.

This is the first backport too so this will set precedence for future backports and having feedback from dev is very important. LGTM from me.

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a brief run through. Parrity with the latest e2e tests would be great, but it's a rather large investment.

The check-e2e-tags test job and script should be backported as well, to ensure all tests run.

Once this merges as well we should bring in branch protection blocking merging until e2e ci jobs pass (give me a prod when so and i'll update repo settings)

.github/workflows/test.yaml Outdated Show resolved Hide resolved
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this now, given the release of 2.8.3.

Remember to backport the check-e2e-tags check

yonasberhe23 and others added 13 commits April 3, 2024 09:03
* actions on cluster tests

---------

Co-authored-by: Yonas Berhe <yberhe@Yonass-MacBook-Pro.local>
* actions on cluster tests

* initial iteration for cluster drivers tests

* node drivers tests

* rke templates tests

* cloud credentials tests and initial node templates tests

* completed node templates tests

* pod security admissions and policy templates

* MachineDeployments MachineSets and Machines tests

* repositories tests

* filter out tests with @Jenkins tag
* amazon ec2 rke2 cluster tests

* update saveAndWaitForRequest fn

* add loading po and use in test

* updates per change requests

---------

Co-authored-by: Yonas Berhe <yberhe@Yonass-MacBook-Pro.local>
Yonas Berhe and others added 15 commits April 3, 2024 09:03
* Create matrix for E2E job

* Create utility for mapping skipped tests for given dirs

* Allow to filter any dir for given env vars

Add Rancher setup phase in test CI

Restore skip setup variable for other checks

* Cypress config cleanup

* Avoid use of tags for setup test

Add setup tag

* Add specs dir to the matrix

Correct matrix to use each role

Add tag prefix on command

* Correct coverage path

* Simplify cypress utility

* Implement only env var filtering logic

Update env var filtering with a menageable definition

Update CI to filter paths by new logic

Reorganize tests file tree

Add tags for each section

Combine roles and features specs

Update new specs to the tag format

Grouping tags

Fix issues with specs and admin spec/username for login parallelization

Fix issue pre-pending @ character

Remove coupling

Remove Docker stop

Enable all the tests in groups

Allow E2E matrix to fail with strategy flag fail-fast

* Add role for setup in combination to features

* Change tag AND to OR (space instead plus)

* Exclude non tagged tests instead of skip

* Correct standard user name

* Use object for matrix definition; Restore usernames for tests; Remove hackish tag for role

* Pair matrix role tag to multiple matrix features

* Disable failing tests

* Move diagnostic from extension to generic

* Remove build dashboard flag for setup

* Correct screenshot naming to match coverage file naming

* Move Cypress utils out of shell

* Remove View API check for fleet

* Add documentation

* Update skip logic and documentation

* Update env template
* get support page tests
* add navTo method for home page and enabled skipped tests after bug fix rancher/rancher-docs#727
* update support link per rancher#9870
@yonasberhe23 yonasberhe23 merged commit fa03653 into rancher:release-2.8 Apr 3, 2024
18 checks passed
@zube zube bot added [zube]: Done and removed [zube]: Review labels Apr 3, 2024
@yonasberhe23 yonasberhe23 deleted the backport_e2e_tests branch April 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants