-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding noAuth extension loading #10727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richard-cox All of the comments/questions around changing code I'd create a separate issue and do in a separate PR. I wanted your take before doing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When installing (or upgrading to) a version of the extension with noAuth: true we should show the user some kind of warning / notification about the repercussions.
- Somethings a bit broken with the https://github.com/rancher/ui-plugin-examples uk-loacle extension
- there's a bad app version index.yaml
- (probably related to above) installing 1.1.0 results in an install reporting as 1.0.0... but has the noAuth flag in... but the id loaded is uk-locale-0.1.0
- Edit:
Installing theI hit the same issue in another branch. I think this is a general bug in their extensionKamaji
extension results in a new cluster explorerMultitenancy Management
menu option. Clicking this in 2.9-head shows some kind of landing zone, clicking this with this branch gives anProduct Multitenancy Management not found
error. Not quite sure how it's so, but required investigating
I've created a PR to address this here: rancher/ui-plugin-examples#38 |
a63f9f9
to
5b6ae69
Compare
install-banner.mp4update-banner.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment / suggestion regarding the warning
…install or update will be loaded without auth
5b6ae69
to
292c57d
Compare
Summary
Adding noAuth extension loading. This will allow specific extensions (such as extensions locale or login page modifications) to load even if the user isn't authenticated.
Fixes #9814
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
To test you can used the extensions in this repo https://github.com/rancher/ui-plugin-charts.
The uk-locale extension is one that can be loaded without authentication.
To verify you can check to see if the locale is present at the login screen:
You can also verify that the script tags are present in the head tag:
Checklist