Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Added validation to AzureAD #10756

Merged
merged 6 commits into from
Apr 12, 2024

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Apr 4, 2024

Summary

Fixes #10771

Added validation to AzureAD configuration

Occurred changes and/or fixed issues

  • Fixed validation for AzureAD
  • Replaced labels with translations

Technical notes summary

Had to use fvExtraRules() for validation since this.model() is used to set the values and it is undefined when data() is run, so default validation would be using this.value instead, which is incorrect.

Areas or cases that should be tested

  • Go to Users & Authentication -> Auth provider ->AzureAD
  • 'Enable' button should be disabled before any information is entered
  • 'Enable' button should be enabled once Tenant ID, Application ID, and Application Secret are populated
  • Switch 'Endpoints' to 'Custom'
  • 'Enable' button should be disabled before any information is entered
  • 'Enable' button should be enabled once Endpoint, Graph Endpoint, Token Endpoint, and Auth Endpoint are populated
  • Press enable and finish the setup. Azure AD should be successfully enabled.
  • Check that the steps from above apply to edit.

Areas which could experience regressions

Editing the list of users who have access can be affected

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@github-actions github-actions bot modified the milestones: v2.9.0, v2.9.next1 Apr 8, 2024
@eva-vashkevich eva-vashkevich changed the title [FEAT] Added DeviceAuthEndpoint to AzureAD [FEAT] Added validation to AzureAD Apr 8, 2024
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good overall. The only comments that I left are based on a few observations that I made during review.

shell/edit/auth/__tests__/azuread.test.ts Outdated Show resolved Hide resolved
shell/edit/auth/__tests__/azuread.test.ts Outdated Show resolved Hide resolved
shell/edit/auth/azuread.vue Outdated Show resolved Hide resolved
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@eva-vashkevich eva-vashkevich merged commit 2064426 into rancher:master Apr 12, 2024
25 checks passed
@eva-vashkevich eva-vashkevich deleted the iss10616 branch April 12, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AzureAD configuration page does not have validation
2 participants