Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automation: address failing/flaky tests #10783

Merged
merged 2 commits into from
Apr 11, 2024
Merged

automation: address failing/flaky tests #10783

merged 2 commits into from
Apr 11, 2024

Conversation

yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Apr 10, 2024 •
edited
Loading

Summary

Fixes #rancher/qa-tasks#1278

  • address failing tests
  • add missing tags to some of our older tests (created before check-e2e-tags test job)
  • clean up code

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@yonasberhe23 yonasberhe23 requested a review from izaac April 10, 2024 21:08
@yonasberhe23 yonasberhe23 added area/ci CI and automation related, e.g. GitHub Actions [zube]: Review labels Apr 10, 2024
izaac
izaac approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get it in once the drone checks pass :shipit:

@yonasberhe23 yonasberhe23 merged commit d8c0cf6 into rancher:master Apr 11, 2024
25 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_flaky_tests branch April 11, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaac izaac izaac approved these changes

Assignees

@yonasberhe23 yonasberhe23

Labels
area/ci CI and automation related, e.g. GitHub Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yonasberhe23 @izaac