Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for adding issue to the GH Project board #10830

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Apr 18, 2024

Fixes a small bug with the GH Project script - to handle the case where an issue is not in any project boards.

@nwmac nwmac added the QA/None label Apr 18, 2024
@nwmac nwmac added this to the v2.9.0 milestone Apr 18, 2024
@nwmac nwmac requested a review from richard-cox April 18, 2024 07:49
@nwmac nwmac self-assigned this Apr 18, 2024
@@ -320,15 +320,15 @@ async function processOpenOrEditAction() {
console.log('---------');

// Is the issue on the board?
if (!prjIssue[ghProject.id]) {
if (!prjIssue || !prjIssue[ghProject.id]) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these could just be !prjIssue?.[ghProject.id], but both do the same thing

@nwmac nwmac merged commit 9cc17f1 into rancher:master Apr 18, 2024
27 checks passed
@nwmac nwmac deleted the gh-project-fixes branch April 18, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants