Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Project automation - fix review state name #10837

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Apr 18, 2024

Should be 'Review' not 'In Review'

Also updated the logging

@nwmac nwmac added this to the v2.9.0 milestone Apr 18, 2024
@nwmac nwmac requested a review from richard-cox April 18, 2024 13:30
@nwmac nwmac self-assigned this Apr 18, 2024
@nwmac nwmac force-pushed the gh-projectx-fix-review-state-name branch from 3f1ecea to 79d3238 Compare April 18, 2024 13:32
@nwmac nwmac requested a review from aalves08 April 18, 2024 15:52
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, thought i'd approved this

@nwmac nwmac merged commit 6527564 into rancher:master Apr 19, 2024
27 checks passed
@nwmac nwmac deleted the gh-projectx-fix-review-state-name branch April 19, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants