Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace default values of props using global variables with computed case #10848

Merged

Conversation

cnotv
Copy link
Contributor

@cnotv cnotv commented Apr 19, 2024

Summary

Fixes #10829

As mentioned in the issue, this is a safe migration to Vue3 with limited use cases.
Using computed values based on props using i18n default values should be sufficient to not break anywhere.

A first attempt to use the global variable t has been carried out, unfortunately, it's not exposed in a prop scope and cannot be used.

Finally, as you can see by the commits and logs, it's mandatory to set a default empty value regardless, to not break existing logic.

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@github-actions github-actions bot added this to the v2.9.0 milestone Apr 19, 2024
@cnotv cnotv force-pushed the feature/10829-default-value-global-var-store branch from 9820a16 to 65c0e24 Compare April 19, 2024 15:40
@cnotv cnotv merged commit c298d64 into rancher:master Apr 22, 2024
27 checks passed
nwmac added a commit to nwmac/dashboard that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace default values of props using global variables with computed case
3 participants