Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate allocatable vGPUs number in Harvester clusters creation #10911

Merged
merged 1 commit into from
May 2, 2024

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented Apr 30, 2024

Summary

Fixes #10906

Occurred changes and/or fixed issues

Technical notes summary

Adding a validation messsage in case the number of available vGpus are less then the number of cluster nodes.

Areas or cases that should be tested

  • Create a new Harvester Cluster
  • Assign a vGpus
  • Add other nodes so their number is more then the allocatable vGPus
  • Click on create button

Areas which could experience regressions

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this change properly prevents over allocating vGPUs and allows for creating the cluster after the problem has been resolved

vgpu-over-allocate

@torchiaf torchiaf merged commit c434fdb into rancher:master May 2, 2024
26 checks passed
@torchiaf torchiaf mentioned this pull request Jul 10, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You can allocate a 3 node RKE2 cluster when you only have one available vGPU
2 participants