Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky tests - manager and explorer #10931

Merged
merged 1 commit into from
May 3, 2024
Merged

fix flaky tests - manager and explorer #10931

merged 1 commit into from
May 3, 2024

Conversation

yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented May 1, 2024 •
edited
Loading

Summary

Fixes #

  • Most of these issues addressed in this PR are timing issues so adding .waitForPage() should help with flakiness
  • Pod Security Admissions and Repositories tests, it was discovered that duplicate entries were being created (when creating/cloning) so adding a page reload when multiple entries with the same name exist to resolve this.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@yonasberhe23 yonasberhe23 marked this pull request as draft May 1, 2024 23:49
@yonasberhe23 yonasberhe23 force-pushed the fix_repo_test branch 4 times, most recently from f16b8db to ea59d02 Compare May 2, 2024 19:10
@yonasberhe23 yonasberhe23 added this to the v2.9.0 milestone May 2, 2024
@yonasberhe23 yonasberhe23 requested a review from izaac May 2, 2024 19:43
@yonasberhe23 yonasberhe23 changed the title fix repositories test fix flaky tests - manager and explorer May 2, 2024
@yonasberhe23 yonasberhe23 force-pushed the fix_repo_test branch 3 times, most recently from b61e9e6 to 284dcb5 Compare May 3, 2024 00:28
@yonasberhe23 yonasberhe23 marked this pull request as ready for review May 3, 2024 00:35
@yonasberhe23 yonasberhe23 marked this pull request as draft May 3, 2024 05:43
@yonasberhe23 yonasberhe23 force-pushed the fix_repo_test branch 2 times, most recently from eed8016 to 90077c1 Compare May 3, 2024 22:12
@yonasberhe23 yonasberhe23 marked this pull request as ready for review May 3, 2024 22:29
izaac
izaac approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonasberhe23 yonasberhe23 merged commit c7ebcea into rancher:master May 3, 2024
26 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_repo_test branch May 16, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaac izaac izaac approved these changes

Assignees

@yonasberhe23 yonasberhe23

Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yonasberhe23 @izaac