Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for resource search and namespace filter issue #10932

Merged
merged 2 commits into from
May 7, 2024

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented May 2, 2024

Summary

Fixes #8656

Adds e2e tests for the issue where the resource search dialog appeared below the namespace filter when opened using the keyboard shortcut.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@nwmac nwmac added this to the v2.9.0 milestone May 2, 2024
@nwmac nwmac self-assigned this May 2, 2024
@nwmac nwmac requested review from richard-cox and aalves08 and removed request for richard-cox May 2, 2024 13:36
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit da47da7 into rancher:master May 7, 2024
33 checks passed
@nwmac nwmac deleted the add-e2e-tests-for-resource-search-bug branch May 7, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The namespace selector is still visible during "Research search"
2 participants