Select vGpus by id instead of vGpu type #10934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
torchiaf
force-pushed
the
10908-vgpu-profiles-2-9
branch
from
6ac62fa
to
1cd2015
Compare
rak-phillip
approved these changes
May 2, 2024
There was a problem hiding this comment.
LGTM - @torchiaf and I synced OOB to discuss the changes and review the functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10908
Occurred changes and/or fixed issues
Technical notes summary
This will fix a modeling issue. vGpu are select by type where we should use vGpu's id since there can be multiple vGpu profiles associated with the same vGpu type.
Areas or cases that should be tested
Harvester cluster's creation
Areas which could experience regressions
Screenshot/Video
Checklist