Fixing an azuread test where the wrong auth provider is being selected #11201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not aware that any providers have been removed. We should maybe try and select by a data test id that we add, or by something more stable than the index |
codyrancher
force-pushed
the
azure-ad-test
branch
3 times, most recently
from
ac4ca00
to
56bace6
Compare
codyrancher
commented
Jun 10, 2024
| @@ -27,6 +27,6 @@ export default class AuthProviderPo extends PagePo { | |||
| } | |||
|
|
|||
| selectAzureAd() { | |||
| return this.self().find('[data-testid="select-icon-grid-3"]').click(); | |||
| return this.self().find('[data-testid="select-icon-grid-AzureAD"]').click(); | |||
There was a problem hiding this comment.
Switched to name so the test is more resilient and not dependent on list order.
codyrancher
commented
Jun 10, 2024
Comment on lines
-40
to
-43
| gridElementExistance(groupIndex = 0, itemIndex = 0, assertion: string) { | ||
| this.self().find(`[data-testid="cluster-manager-create-grid-${ groupIndex }-${ itemIndex }"]`).should(assertion); | ||
| } | ||
|
|
There was a problem hiding this comment.
This was only used in one location and I removed it because this was a little clunky and there was already an existing lookup by name that could be used instead.
It appears that there are 2 less providers being used now. Is this a backend issue?
codyrancher
force-pushed
the
azure-ad-test
branch
from
56bace6
to
3256f2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that the order of the providers has changed (changes all the time?) so this broke the reliance on looking up elements based on index.
Technical notes summary
This change makes the relevant tests more robust by relying on names instead of indices.
Areas which could experience regressions
Only our tests
Checklist