Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: Add support for noAuth in publish script #11220

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Jun 13, 2024

Summary

Fixes #11219

Updates the extension publish script so that if the extension's package.json file specifies noAuth then this will be wired into the extension Helm package.

Note: I also updated some of the log statements to refer to Extensions rather than Plugins.

Areas or cases that should be tested

No manual testing - we will test this as part of Extensions development.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@nwmac nwmac added this to the v2.9.0 milestone Jun 13, 2024
@nwmac nwmac requested a review from aalves08 June 13, 2024 09:05
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @nwmac

@nwmac nwmac merged commit 71712d8 into rancher:master Jun 13, 2024
36 checks passed
@nwmac nwmac deleted the extensions-publish-noauth branch June 13, 2024 10:15
nwmac added a commit to nwmac/dashboard that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions: Publish script does not support noAuth
2 participants