update docs for noAuth annotation #11221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwmac
requested changes
Jun 13, 2024
| @@ -89,7 +90,8 @@ ___`./pkg/my-package/package.json`___ | |||
| "catalog.cattle.io/rancher-version": ">= 2.7.7-0 < 2.9.0-0", | |||
| "catalog.cattle.io/ui-extensions-version": ">= 1.1.0", | |||
| "catalog.cattle.io/ui-version": ">= 2.7.7-0 < 2.9.0-0", | |||
| "catalog.cattle.io/display-name": "My Super Great Extension" | |||
| "catalog.cattle.io/display-name": "My Super Great Extension", | |||
| "noAuth": "true" | |||
There was a problem hiding this comment.
noAuth is at the same level as annotations - it is not an annotation itself since it wires in differently - the value is a boolean, not a string
There was a problem hiding this comment.
Good catch.... I didn't notice that. NO_AUTH=$(jq -r '.rancher.noAuth' < ${PACKAGE_JSON}). You're right
|
@nwmac up for review again: |
nwmac
requested changes
Jun 15, 2024
| @@ -90,7 +95,8 @@ ___`./pkg/my-package/package.json`___ | |||
| "catalog.cattle.io/ui-extensions-version": ">= 1.1.0", | |||
| "catalog.cattle.io/ui-version": ">= 2.7.7-0 < 2.9.0-0", | |||
| "catalog.cattle.io/display-name": "My Super Great Extension" | |||
| } | |||
| }, | |||
| "noAuth": "true" | |||
There was a problem hiding this comment.
Its just a boolean, not a string - "noAuth": true
nwmac
approved these changes
Jun 17, 2024
nwmac
pushed a commit
to nwmac/dashboard
that referenced
this pull request
Oct 24, 2024
* update docs * update docs * address pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist