Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fleet status calculation #11249

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented Jun 17, 2024

Summary

Fixes #11181

Occurred changes and/or fixed issues

When Rancher is freshly installed, it takes some time to create cattle-fleet-local-system/fleet-agent StatefulSet in local cluster.
We are excluding it from fleet agent health checks during this startup period.

Technical notes summary

During the startup period:

  • cattle-fleet-local-system/fleet-agent is null
  • Rancher is able to create and communicate with new downstream clusters
  • cattle-fleet-system/fleet-controller is OK

So it's reasonable to calculate the fleet agent status using only cattle-fleet-system/fleet-controller and include cattle-fleet-local-system/fleet-agent when available.

Areas or cases that should be tested

  • cluster explorer -> local -> Dashboard page -> Health boxes -> fleet

How to test

  • Install Rancher 2.9.x
  • Check the fleet health box (see screenshot)
  • `cattle-fleet-local-system/fleet-agent is created by Rancher after ~5/10 minutes (docker installation)

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

… it is created by Rancher

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf added this to the v2.9.0 milestone Jun 17, 2024
@torchiaf torchiaf requested a review from aalves08 June 17, 2024 09:58
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torchiaf torchiaf merged commit d0cee47 into rancher:master Jun 18, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fleet status on local cluster dashboard shows red
2 participants