Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove every reference to .nuxt global option #11265

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Remove every reference to .nuxt global option #11265

merged 4 commits into from
Jun 21, 2024

Conversation

cnotv
Copy link
Contributor

@cnotv cnotv commented Jun 18, 2024 •
edited
Loading

Summary

Fixes #11260

Removed pretty much everything related to nuxt properties in the entry initialization, plus everything mentioned in the issue.

Replaced custom error handling from Nuxt dead code, with existing implementation.

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Fail-whale seems to load correctly still.

Kapture.2024-06-18.at.21.19.22.mp4

This was the previous error page, following the E2E tests /public, which redirected here:
image

Now is instead fail-whale as well.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@cnotv cnotv requested a review from codyrancher June 18, 2024 19:22
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.10.0 milestone Jun 18, 2024
@cnotv cnotv force-pushed the feature/11260-remove-nuxt-globals branch from aaf51fa to 98843fc Compare June 18, 2024 21:30
cnotv
cnotv commented Jun 19, 2024
View reviewed changes
shell/initialize/entry-helpers.js
* @param {*} context
* @param {*} message
*/
const errorRedirect = (context, message) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed that we are using something else for errors which is a leftover of Nuxt, instead of the fail-whale path.
For some reason a simple action commit is not sufficient, so I've set a function wrapper and forced redirect after setting the error.

@cnotv cnotv force-pushed the feature/11260-remove-nuxt-globals branch from 6e6664f to 0544f61 Compare June 19, 2024 19:18
codyrancher
codyrancher reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@codyrancher codyrancher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm comfortable to approve if we know that this won't affect our CDN assets. Do we know if that's true here?

@cnotv
Copy link
Contributor Author

cnotv commented Jun 20, 2024

I'm comfortable to approve if we know that this won't affect our CDN assets. Do we know if that's true here?

What do you refer to when you talk about CDN assets?

@codyrancher
Copy link
Contributor

I'm comfortable to approve if we know that this won't affect our CDN assets. Do we know if that's true here?

What do you refer to when you talk about CDN assets?

Do the build artifacts still get copied correctly for
image

Or the assets that get built into rancher.

@cnotv
Copy link
Contributor Author

cnotv commented Jun 20, 2024

I'm comfortable to approve if we know that this won't affect our CDN assets. Do we know if that's true here?

What do you refer to when you talk about CDN assets?

Do the build artifacts still get copied correctly for image

Or the assets that get built into rancher.

Do you mean the path of the assets?
I have no idea why my changes should affect the vue.config or the index resource, let's have maybe a chat about this, because like this I don't know what are you trying to say.

@cnotv
Copy link
Contributor Author

cnotv commented Jun 20, 2024

As reviewed today, there are no distributed files used within the .nuxt path and the assets are all bundled within the dist folder.

@cnotv cnotv merged commit c36b071 into rancher:master Jun 21, 2024
27 checks passed
@gaktive gaktive modified the milestones: v2.10.0, v2.9.0 Jul 3, 2024
nwmac pushed a commit to nwmac/dashboard that referenced this pull request Oct 24, 2024
@cnotv @nwmac
Remove every reference to .nuxt global option (rancher#11265)
a00d2ba 
* Remove unused rehydratation plugin

* Remove any reference to the .nuxt folders

* Remove globalApp nuxt and any reference or use case to nuxt.error

* Replace errors handling with existing fail-whale logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyrancher codyrancher codyrancher approved these changes

Assignees

@cnotv cnotv

Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.

Remove every reference to .nuxt global option
3 participants
@cnotv @codyrancher @gaktive