Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure v2.6 Security section #3761

Merged
merged 8 commits into from
Jan 17, 2022
Merged

Restructure v2.6 Security section #3761

merged 8 commits into from
Jan 17, 2022

Conversation

macedogm
Copy link
Member

@macedogm macedogm commented Dec 30, 2021

This is an initial work preparing for the updates to CIS hardening guides for v2.6 - rancher/rancher#35735.

  1. Remove v2.5 related hardening guides from v2.6 and mentioned that v2.6 guides are being updated.
  2. Added aliases for removed pages.
  3. Update Kubernetes security best practices.
  4. Fix some small typos.

Signed-off-by: Guilherme Macedo <guilherme.macedo@suse.com>
Signed-off-by: Guilherme Macedo <guilherme.macedo@suse.com>
Signed-off-by: Guilherme Macedo <guilherme.macedo@suse.com>
@vincent99
Copy link
Contributor

Removed or renamed files == broken links in search engines indefinitely. Setup redirects in frontmatter to preserve all existing paths and go to wherever is appropriate.

@macedogm
Copy link
Member Author

@vincent99 thanks for catching this. Is this - https://github.com/rancher/docs/blob/master/nginx.conf - the place where I can set those redirects or you mean to just preserve the original _index.md of the affected page and set the redirect there?

@macedogm macedogm added this to the v2.6.4 milestone Dec 30, 2021
@macedogm macedogm marked this pull request as draft December 30, 2021 15:16
@vincent99
Copy link
Contributor

Nginx is easier for bulk pattern matching/folder renames, aliases for individual pages.

@cbron cbron self-requested a review December 30, 2021 15:40
@macedogm macedogm removed this from the v2.6.4 milestone Dec 30, 2021
Signed-off-by: Guilherme Macedo <guilherme.macedo@suse.com>
@macedogm
Copy link
Member Author

@vincent99 thanks again for the tip. I added aliases for the removed pages. No links will be harmed now 😂

@macedogm macedogm marked this pull request as ready for review December 30, 2021 16:18
@macedogm macedogm requested a review from a team December 30, 2021 16:18
@macedogm macedogm marked this pull request as draft December 31, 2021 00:34
Signed-off-by: Guilherme Macedo <guilherme@gmacedo.com>
Signed-off-by: Guilherme Macedo <guilherme@gmacedo.com>
@macedogm macedogm marked this pull request as ready for review January 1, 2022 13:48
Signed-off-by: Guilherme Macedo <guilherme.macedo@suse.com>
@cbron cbron self-requested a review January 3, 2022 14:17
@jtravee jtravee requested a review from btat January 10, 2022 15:07
@btat btat merged commit 9143ea4 into rancher:master Jan 17, 2022
@macedogm macedogm deleted the rancher/35735-hardening-docs branch January 17, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants