Update RKE2 config ref YAML options

[btat]

No description provided.

[snasovich]

Added some suggestions.
Would appreciate for @thedadams to review my comments as I'm not exactly solid on their correctness.

[snasovich]

This statement gives the impression that we specify which chart to install which I don't believe is the case. E.g. if no chartValues are specified, RKE2 still installs whatever charts it needs; this section is purely to allow customizing values for the charts RKE2 installs (either by default or based on other settings passed - e.g. machineGlobalConfig.cni sets which CNI is to be installed and related Helm chart is installed automatically).

[thedadams]

Technically speaking, I believe it does mean that Rancher will ask RKE2 to install the chart. The issue is whether or not RKE2 knows about the chart. If RKE2 doesn't know about the chart, then Rancher asking it to install it won't work.

[snasovich]

Thank you for the clarification here. If we make the suggested change few lines above, I think this can be left as is.
On a side note, I'm wondering if there is a way to reference a comprehensive list of charts coming from RKE2?
I couldn't find it documented in RKE2 docs.
@cwayne18 @brandond @briandowns

[brandond]

I don't believe this does enable the chart. It just creates a HelmChartConfig for the chart with the matching name, which will provide values to that chart IF it is enabled. I would love to have this confirmed though.

The RKE2 bundled charts live in the rke2-charts repo, and the versions packaged in a given release can be found in the Dockerfile. Some of these, such as the cloud-provider and CNI charts, only have one active at a time. We don't document this anywhere else, at the moment.

[btat]

Would the consensus be to remove the line for now and add back any additional info once it's been confirmed?

@snasovich @thedadams @brandond

[snasovich]

I agree, let's just remove this line - the documentation is fine without it.

[brandond]

I don't believe this does enable the chart. It just creates a HelmChartConfig for the chart with the matching name, which will provide values to that chart IF it is enabled. I would love to have this confirmed though.

The RKE2 bundled charts live in the rke2-charts repo, and the versions packaged in a given release can be found in the Dockerfile. Some of these, such as the cloud-provider and CNI charts, only have one active at a time. We don't document this anywhere else, at the moment.

[snasovich]

Some minor updates requested, otherwise LGTM

Feedback addressed