[v2.8] Bump go toolchain #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiannistri
added
dependencies
vatsalparekh
previously requested changes
Sep 10, 2024
| @@ -2,7 +2,7 @@ module github.com/rancher/eks-operator | |||
|
|
|||
| go 1.22.0 | |||
|
|
|||
| toolchain go1.22.5 | |||
| toolchain go1.22.7 | |||
|
|
|||
| replace k8s.io/client-go => k8s.io/client-go v0.28.6 | |||
|
|
|||
There was a problem hiding this comment.
Wondering why no go dependencies were updated in this backport since go version is same across all other branches
There was a problem hiding this comment.
I believe the reason why we didn't get any dependabot PRs for 2.8 is because it's still using the AWS SDK for Go (v1) which is in maintenance mode and is only receiving critical bug fixes and security updates. In addition to that, this version of the SDK (v1) is not using the same stdlib dependencies that the newer version of the SDK (v2) uses.
I think we should consider bumping this to its latest version but such a change should probably be done separately and be followed by sufficient testing.
yiannistri
dismissed
vatsalparekh’s stale review
I have responded to Vatsal's comment above.
furkatgofurov7
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bump Go compiler version to address CVE-2024-34156
Also updated Scan workflow to use the image that is used for the operator instead of the e2e tests.
Checklist: