Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure /usr/local/bin exists on COS_PERSISTENT #172

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Ensure /usr/local/bin exists on COS_PERSISTENT #172

merged 1 commit into from
Jul 18, 2022

Conversation

kkaempf
Copy link
Contributor

@kkaempf kkaempf commented Jul 15, 2022

rancher-system-agent needs it

Signed-off-by: Klaus Kämpf kkaempf@suse.de

@kkaempf
Ensure /usr/local/bin exists on COS_PERSISTENT
7ee4bcc 
rancher-system-agent needs it

Signed-off-by: Klaus Kämpf <kkaempf@suse.de>
@kkaempf kkaempf mentioned this pull request Jul 18, 2022
Closed
@kkaempf
Copy link
Contributor Author

kkaempf commented Jul 18, 2022

Hmm, maybe it's better to add /usr/local/bin to PERSISTENT_STATE_PATHS ?!

mudler
mudler approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mudler
Copy link
Contributor

mudler commented Jul 18, 2022

Hmm, maybe it's better to add /usr/local/bin to PERSISTENT_STATE_PATHS ?!

I wouldn't say so, /usr/local is mounted out from the persistent partition

@kkaempf kkaempf merged commit 391cb6f into master Jul 18, 2022
@kkaempf kkaempf deleted the ensure-essential-persistent-paths branch July 18, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler mudler approved these changes

@davidcassany davidcassany Awaiting requested review from davidcassany

Assignees
No one assigned
Labels
None yet
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkaempf @mudler