Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cypress tests for Machine Registration #209

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Add Cypress tests for Machine Registration #209

merged 2 commits into from
Jul 27, 2022

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Jul 25, 2022 •
edited
Loading

Fix rancher/dashboard#196

  • Write before each to clean resources ✔️
  • Write a function to create machine registration ✔️
  • Test with default options ✔️
  • Test with custom namespace ✔️
  • Test with labels and annotations ✔️
    I can create a machine registration but I cannot check that they appear in the UI because they are with the attribute disabled
  • Test with custom cloud config ❌
    Stuck due to this bug anyway Elemental - Cannot see the cloud config after creating a machine registration elemental-ui#15
  • Delete machine registration (done in the before each section, don't know if it need a dedicated test though

@juadk juadk added the kind/QA label Jul 25, 2022
@juadk juadk self-assigned this Jul 25, 2022
@juadk juadk force-pushed the add_machine_reg_tests branch 2 times, most recently from fbcff61 to eb33273 Compare July 27, 2022 09:39
@juadk
Copy link
Contributor Author

juadk commented Jul 27, 2022 •
edited
Loading

image
Test with custom cloud config is skipped waiting a fix for rancher/elemental-ui#15
I just opened a separate issue (#215) to track the missing test.

@juadk juadk requested a review from ldevulder July 27, 2022 13:03
@juadk juadk marked this pull request as ready for review July 27, 2022 13:11
ldevulder
ldevulder approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldevulder ldevulder merged commit ff8127a into master Jul 27, 2022
@ldevulder ldevulder deleted the add_machine_reg_tests branch July 27, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldevulder ldevulder ldevulder approved these changes

Assignees

@juadk juadk

Labels
kind/QA
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI - Create Machine Registration from the UI
2 participants
@juadk @ldevulder