Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootargs.cfg #226

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Update bootargs.cfg #226

merged 1 commit into from
Jul 29, 2022

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Jul 29, 2022

Test disabling rd.neednet

Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes #25 🤞🏻

@kkaempf
Copy link
Contributor

kkaempf commented Jul 29, 2022

How does this relate to

ContainSubstring("rd.neednet=1"),
?

Also there's framework/files/etc/cos/bootargs.cfg and framework/cos/etc/cos/bootargs.cfg and the OBS package build overwrites the latter with the former 🤦🏻

@Itxaka
Copy link
Contributor Author

Itxaka commented Jul 29, 2022

Ignore the tests, they currently don't run and @ldevulder is working on restoring them.

@Itxaka
Copy link
Contributor Author

Itxaka commented Jul 29, 2022

Framework/cos is the default files needed from elemental-toolkit and then we override them with the especific elemental ones.

It's on the readme, as it explains that those cos files get auto updated from elemental-toolkit, while the files ones are overlayed on top. Things like the default services from cos (cos-setup-fs for example) are part of the cos framework, while other services like the elemental-system-agent are elemental specific and go into the files folder.

Could probably do with a cleanup and merge of those, not sure what we would lose by just merging them....

@ldevulder
Copy link
Contributor

Ignore the tests, they currently don't run and @ldevulder is working on restoring them.

I'm on the E2E tests, not this smoke on yet, but I can re-add them later for sure. Is these smoke tests were part ofwhat was called Integration Tests?

@Itxaka
Copy link
Contributor Author

Itxaka commented Jul 29, 2022

I'm on the E2E tests, not this smoke on yet, but I can re-add them later for sure. Is these smoke tests were part ofwhat was called Integration Tests?

yep, it run the tests under the smoke dir only :)

@Itxaka Itxaka merged commit 79725af into master Jul 29, 2022
@Itxaka Itxaka deleted the Itxaka-patch-1 branch July 29, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants