E2E: add SetTimeout function for slow runner #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldevulder
commented
Aug 2, 2022
Itxaka
approved these changes
Aug 2, 2022
|
Just set it to draft, as I saw some syntax error during the validation on my lab: https://github.com/ldevulder/elemental/runs/7633631280?check_suite_focus=true#step:3:955 |
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
As it cannot be handled because of the workflow_run one. Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
ldevulder
force-pushed
the
fix-e2e-timeout
branch
from
63e642f
to
ea409b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our self-hosted runner can be slow sometimes (SSD might be needed!), this PR adds a funciton to increase the timeout easily based on a env variable (
TIMEOUT_SCALE). Set it to 2, should be enough (but will see after testing).This PR also fixes small issues.