Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup parts referring to outdated stack #249

Merged
merged 3 commits into from
Aug 4, 2022

Conversation

davidcassany
Copy link
Contributor

This commit mostly removes references to outdated/dropped projects such
as rancherd, ros-installer and ros-operator. In addition it sliglty
adapts the surrounding text not to be completely wrong.

Note this is not a rewrite. It just tries to fix obsolete and even
wrong text, it is not aiming to provide missing contents.

Signed-off-by: David Cassany dcassany@suse.com

@davidcassany davidcassany marked this pull request as draft August 3, 2022 14:59
docs/architecture.md Outdated Show resolved Hide resolved
This commit mostly removes references to outdated/dropped projects such
as rancherd, ros-installer and ros-operator. In addition it sliglty
adapts the surrounding text not to be completely wrong.

Note this is not a rewrite. It just tries to fix obsolete and even
wrong text, it is not aiming to provide missing contents.

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany marked this pull request as ready for review August 3, 2022 15:26
docs/architecture.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge as-is and iterate upon

Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/architecture.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/customizing.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
docs/upgrade.md Show resolved Hide resolved
docs/upgrade.md Show resolved Hide resolved
Copy link
Contributor

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davidcassany and others added 2 commits August 4, 2022 11:51
Co-authored-by: Francesco Giudici <francesco.giudici@suse.com>
Signed-off-by: David Cassany Viladomat <dcassany@suse.de>
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany merged commit f285e51 into master Aug 4, 2022
@davidcassany davidcassany deleted the cleanup_outdated_stack_docs branch August 4, 2022 10:28
@davidcassany davidcassany mentioned this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants