Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plans doc #264

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Add plans doc #264

merged 3 commits into from
Aug 9, 2022

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Aug 9, 2022

Fixes #242

Signed-off-by: Itxaka igarcia@suse.com

Signed-off-by: Itxaka <igarcia@suse.com>
@Itxaka Itxaka added kind/documentation Improvements or additions to documentation area/elemental labels Aug 9, 2022
Copy link
Contributor

@nunix nunix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added introduction sentences for the examples and rephrased introduction.

docs/elemental-plans.md Outdated Show resolved Hide resolved
docs/elemental-plans.md Outdated Show resolved Hide resolved
docs/elemental-plans.md Outdated Show resolved Hide resolved
docs/elemental-plans.md Show resolved Hide resolved
docs/elemental-plans.md Outdated Show resolved Hide resolved
docs/elemental-plans.md Outdated Show resolved Hide resolved
docs/elemental-plans.md Outdated Show resolved Hide resolved
docs/elemental-plans.md Outdated Show resolved Hide resolved
docs/elemental-plans.md Outdated Show resolved Hide resolved
docs/elemental-plans.md Outdated Show resolved Hide resolved
Itxaka and others added 2 commits August 9, 2022 12:35
Co-authored-by: Nuno do Carmo <darthnunix@gmail.com>
Adds the title to them and makes them collapsed so they dont take over
the whole page

Signed-off-by: Itxaka <igarcia@suse.com>
@Itxaka
Copy link
Contributor Author

Itxaka commented Aug 9, 2022

@nunix I added most of your comments except the examples header as I changed it to be an example block AND collapsed so they dont take the whole page and can be clicked to expand

@nunix nunix self-requested a review August 9, 2022 10:50
@Itxaka Itxaka merged commit b23df1c into rancher:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/elemental kind/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom bootstrap local plan
3 participants