Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: create rke2 cluster #284

Merged
merged 4 commits into from
Aug 25, 2022
Merged

e2e: create rke2 cluster #284

merged 4 commits into from
Aug 25, 2022

Conversation

ldevulder
Copy link
Contributor

@ldevulder ldevulder commented Aug 24, 2022

Should fix #248.

Verification run on my lab (limited to 2 nodes, 3 killed my laptop): https://github.com/ldevulder/elemental/actions/runs/2920853424

Signed-off-by: Loic Devulder <ldevulder@suse.com>
K3s cluster provisioning is in Tech Preview in Rancher, so it's better
to use the supported one instead for the CI.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it looks great, but I would wait for @Itxaka

.github/workflows/e2e.yaml Show resolved Hide resolved
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
Signed-off-by: Loic Devulder <ldevulder@suse.com>
@ldevulder
Copy link
Contributor Author

For me it looks great, but I would wait for @Itxaka

He is an vacation until this end of the month, I have other changes to do in the E2E tests, so I will merge this PR (verification run is green). And I will change after if he add some comments/changes.

@ldevulder ldevulder merged commit 1df7f98 into main Aug 25, 2022
@ldevulder ldevulder deleted the e2e-create-rke2-cluster branch August 25, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

e2e: add test with RKE2
3 participants