Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump some Golang dependencies #305

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Bump some Golang dependencies #305

merged 2 commits into from
Sep 1, 2022

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Sep 1, 2022

@juadk juadk marked this pull request as draft September 1, 2022 08:55
@ldevulder
Copy link
Contributor

To avoid doing this each time a module version is bumped, maybe we can do this:

  • remove go.sum file
  • have go.mod with only this:
module github.com/rancher/elemental/tests

go 1.18
  • do these command in the make deps section:
deps: 
        go install -mod=mod github.com/onsi/ginkgo/v2/ginkgo
        go install -mod=mod github.com/onsi/gomega
        go mod tidy

In that cse the latest versions of ginkgo and gomega are downloaded and all the deps are calculated with the 'mod tidy` command on each run. This will avoid CI issues on the tests. Tested locally ob my lab and it seems to works.

@juadk @Itxaka WDYT?

@Itxaka
Copy link
Contributor

Itxaka commented Sep 1, 2022

I no longer understand go dependencies and I dont want to. If that works @ldevulder then its good to me.

@juadk
Copy link
Contributor Author

juadk commented Sep 1, 2022

@ldevulder Let's go with your solution!

It's easier to re-generate them when the tests are started.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
@ldevulder
Copy link
Contributor

I just pushed the changes :-)

@ldevulder ldevulder marked this pull request as ready for review September 1, 2022 13:11
@ldevulder ldevulder merged commit eb5b5c7 into main Sep 1, 2022
@ldevulder ldevulder deleted the update_golang_dependencies branch September 1, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants