Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix github deprecations #463

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Oct 25, 2022

Signed-off-by: Itxaka igarcia@suse.com

Signed-off-by: Itxaka <igarcia@suse.com>
@Itxaka Itxaka requested a review from a team October 25, 2022 13:47
@Itxaka Itxaka enabled auto-merge (squash) October 25, 2022 13:47
@Itxaka Itxaka mentioned this pull request Oct 25, 2022
4 tasks
@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for elemental-docs-staging failed.

Name Link
🔨 Latest commit 4aaf5d0
🔍 Latest deploy log https://app.netlify.com/sites/elemental-docs-staging/deploys/6357e8f5e7f3bb0008d4e1bb

Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look to me, I just don't see where this netlify checks are comming from and what are they supposed to mean/check...

@Itxaka Itxaka merged commit 061409c into rancher:main Oct 25, 2022
id: wait-for-build
with:
token: ${{ secrets.GITHUB_TOKEN }}
checkName: build-all-artifacts
ref: ${{ github.event.pull_request.head.sha || github.sha }}
timeoutSeconds: 1800
- name: Download artifacts
uses: dawidd6/action-download-artifact@v2
uses: dawidd6/action-download-artifact@v2.24.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that this change was needed, as far as I understand dawidd6/action-download-artifact@v2 should point to the latest v2 version, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants