-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the elemental plugin in the UI CI #468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
expect($lis.eq(5)).to.contain('Managed OS Versions'); | ||
expect($lis.eq(6)).to.contain('Managed OS Version Channels'); | ||
expect($lis.eq(7)).to.contain('OS Image Upgrades'); | ||
expect($lis.eq(3)).to.contain('Managed OS Versions'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alexandre talked about dropping these fields as their semantics isn't fully defined yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep exactly
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "epinio-end-to-end-tests", | |||
"name": "elemental-ui-e2e", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
@@ -128,7 +128,11 @@ var _ = Describe("E2E - Install Rancher Manager", Label("install"), func() { | |||
|
|||
// Set specified version if needed | |||
if rancherVersion != "" && rancherVersion != "latest" { | |||
flags = append(flags, "--version", rancherVersion) | |||
if rancherVersion == "devel" { | |||
flags = append(flags, "--devel") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this are exclusive no? You can set --devel AND a version, only --devel will inlcude in the list all the devel versions.
Maybe it will be useful if the latest devel is broken but we need to test with the previous devel version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--devel
isn't needed if you specify a version. We tried this morning and you can set --version 2.7.0.-rc7
and it will install this development/RC version without the need of --devel
. --devel
is useful here to force the installation of the latest development version.
So with the variables in the workflow files you can set this if you always want the latest version (which is needed for UI):
with:
rancher_channel: latest
rancher_version: devel
And this if you want a specific development version:
with:
rancher_channel: latest
rancher_version: 2.7.0-rc4
Same apply with stable
channel, latest
is the latest tagged version and you can specify a version (no devel
in the channel of course).
8370e22
to
aed0a82
Compare
aed0a82
to
c1d2db2
Compare
…ntal into add_elemental_plugin_UI_CI
Fix #445
The new plugin/extension is ready to test so let's integrate in in the CI instead of using a tricky older dev branch.