ci/e2e: variabilize number of nodes #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldevulder
force-pushed
the
e2e-variabilize-node-number
branch
7 times, most recently
from
f5b85fc
to
9303c41
Compare
Itxaka
reviewed
Nov 7, 2022
ldevulder
force-pushed
the
e2e-variabilize-node-number
branch
2 times, most recently
from
d170432
to
b5f5143
Compare
8 tasks
ldevulder
commented
Nov 8, 2022
juadk
reviewed
Nov 8, 2022
juadk
approved these changes
Nov 8, 2022
|
FYI you can change the name of the job to use the number of nodes on it, so its visible on a glance at the job, see https://github.com/rancher/elemental-operator/blob/main/.github/workflows/e2e.yaml#L74 for example Or just push the number of nodes to the job summary so its visible in the job summary: https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/ |
ldevulder
force-pushed
the
e2e-variabilize-node-number
branch
3 times, most recently
from
ae7a0f3
to
2f5d6cb
Compare
This allow to quickly increase the number of nodes to add in the provisioned cluster. Signed-off-by: Loic Devulder <ldevulder@suse.com>
This is to workaround this error: ``` Unexpected type of value '10', expected type: Number. ``` Looks like a GHA bug... Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
ldevulder
force-pushed
the
e2e-variabilize-node-number
branch
from
2f5d6cb
to
c2900cc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to quickly increase the number of nodes to add in the provisioned cluster. Part of #423.
Verification run: https://github.com/rancher/elemental/actions/runs/3416821900.
NOTE: K3s test failed because of a download issue with opensuse.org, nothing related to this PR, and RKE2 is green with 6 nodes.