-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: use auto scaling runner #546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldevulder
force-pushed
the
e2e-use-auto-scaling-runner
branch
24 times, most recently
from
December 1, 2022 15:29
69b9274
to
dc37dc2
Compare
ldevulder
force-pushed
the
e2e-use-auto-scaling-runner
branch
from
December 2, 2022 08:59
6804851
to
ac2a237
Compare
davidcassany
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ldevulder
force-pushed
the
e2e-use-auto-scaling-runner
branch
4 times, most recently
from
December 2, 2022 11:56
a3c3fa9
to
23a31db
Compare
juadk
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice job!! Congrats!
LGTM
ldevulder
force-pushed
the
e2e-use-auto-scaling-runner
branch
3 times, most recently
from
December 2, 2022 13:56
59333c6
to
2751637
Compare
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Use the Dev version from OBS for elemental-operator, as this version is rebuilt each time a push is made on main branch. Signed-off-by: Loic Devulder <ldevulder@suse.com>
This is because we can have sporadic network failures sometimes. Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Adapt the concurrency configuration for E2E tests to better use auto-scaling functionnality. Signed-off-by: Loic Devulder <ldevulder@suse.com>
This is to avoid 'Server Error` on download, it could also speed up the process a little. Signed-off-by: Loic Devulder <ldevulder@suse.com>
ldevulder
force-pushed
the
e2e-use-auto-scaling-runner
branch
from
December 2, 2022 13:58
2751637
to
70b8d5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #482 .
Verification Run on nighly E2E: cannot be triggered manually, but OBS ones are the same
Verification Run on UI: https://github.com/rancher/elemental/actions/runs/3594058243
Verification Run on OBS Stable: https://github.com/rancher/elemental/actions/runs/3594051428
Verification Run on OBS Staging: https://github.com/rancher/elemental/actions/runs/3595999318
Verification Run on OBS Dev: https://github.com/rancher/elemental/actions/runs/3595989715
Note: the error on OBS Dev seems to be related to the newer version of
elemental-operator
withkubebuilder
.EDIT: the artifact download issue is not related to this PR: dawidd6/action-download-artifact#214.