Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: use auto scaling runner #546

Merged
merged 8 commits into from
Dec 2, 2022
Merged

e2e: use auto scaling runner #546

merged 8 commits into from
Dec 2, 2022

Conversation

ldevulder
Copy link
Contributor

@ldevulder ldevulder commented Nov 29, 2022

This should fix #482 .

Verification Run on nighly E2E: cannot be triggered manually, but OBS ones are the same
Verification Run on UI: https://github.com/rancher/elemental/actions/runs/3594058243
Verification Run on OBS Stable: https://github.com/rancher/elemental/actions/runs/3594051428
Verification Run on OBS Staging: https://github.com/rancher/elemental/actions/runs/3595999318
Verification Run on OBS Dev: https://github.com/rancher/elemental/actions/runs/3595989715
Note: the error on OBS Dev seems to be related to the newer version of elemental-operator with kubebuilder.

EDIT: the artifact download issue is not related to this PR: dawidd6/action-download-artifact#214.

@ldevulder ldevulder self-assigned this Nov 29, 2022
@ldevulder ldevulder marked this pull request as draft November 29, 2022 17:58
@ldevulder ldevulder force-pushed the e2e-use-auto-scaling-runner branch 24 times, most recently from 69b9274 to dc37dc2 Compare December 1, 2022 15:29
@ldevulder ldevulder marked this pull request as ready for review December 1, 2022 16:06
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldevulder ldevulder force-pushed the e2e-use-auto-scaling-runner branch 4 times, most recently from a3c3fa9 to 23a31db Compare December 2, 2022 11:56
Copy link
Contributor

@juadk juadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job!! Congrats!
LGTM

@ldevulder ldevulder force-pushed the e2e-use-auto-scaling-runner branch 3 times, most recently from 59333c6 to 2751637 Compare December 2, 2022 13:56
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Use the Dev version from OBS for elemental-operator, as this version is
rebuilt each time a push is made on main branch.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
This is because we can have sporadic network failures sometimes.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Adapt the concurrency configuration for E2E tests to better use
auto-scaling functionnality.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
This is to avoid 'Server Error` on download, it could also speed up the
process a little.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
@ldevulder ldevulder merged commit 1e8c9f9 into main Dec 2, 2022
@ldevulder ldevulder deleted the e2e-use-auto-scaling-runner branch December 2, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

e2e: configure/use auto-scaling for GH runners in GCP
3 participants