-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect elemental support in e2e UI CI #574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juadk
force-pushed
the
417-collect_logs
branch
from
December 9, 2022 13:52
b11c7db
to
1cded77
Compare
juadk
force-pushed
the
417-collect_logs
branch
from
December 9, 2022 14:06
1cded77
to
aa24904
Compare
Itxaka
reviewed
Dec 9, 2022
Itxaka
reviewed
Dec 9, 2022
ldevulder
requested changes
Dec 9, 2022
juadk
force-pushed
the
417-collect_logs
branch
from
December 12, 2022 13:38
99fc47f
to
546a78f
Compare
juadk
force-pushed
the
417-collect_logs
branch
from
December 12, 2022 14:33
546a78f
to
d6ee37a
Compare
ldevulder
requested changes
Dec 12, 2022
ldevulder
reviewed
Dec 12, 2022
ldevulder
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I just forgot to point you to kubectl.Run
function... I did some suggestions to add this.
juadk
force-pushed
the
417-collect_logs
branch
from
December 12, 2022 17:33
429ff6e
to
7656a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #417
Verification Run:
https://github.com/rancher/elemental/actions/runs/3678271212