Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect elemental support in e2e UI CI #574

Merged
merged 8 commits into from
Dec 12, 2022
Merged

Collect elemental support in e2e UI CI #574

merged 8 commits into from
Dec 12, 2022

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Dec 9, 2022

@juadk juadk marked this pull request as ready for review December 9, 2022 14:08
@juadk juadk added the kind/QA label Dec 9, 2022
@juadk juadk self-assigned this Dec 9, 2022
tests/e2e/logs_test.go Outdated Show resolved Hide resolved
tests/e2e/logs_test.go Outdated Show resolved Hide resolved
tests/e2e/logs_test.go Outdated Show resolved Hide resolved
tests/e2e/logs_test.go Outdated Show resolved Hide resolved
@juadk juadk requested a review from ldevulder December 12, 2022 14:42
.github/workflows/master-e2e.yaml Outdated Show resolved Hide resolved
tests/e2e/logs_test.go Outdated Show resolved Hide resolved
tests/e2e/logs_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I just forgot to point you to kubectl.Run function... I did some suggestions to add this.

tests/e2e/logs_test.go Outdated Show resolved Hide resolved
tests/e2e/logs_test.go Show resolved Hide resolved
@juadk juadk merged commit 3fdb7f1 into main Dec 12, 2022
@juadk juadk deleted the 417-collect_logs branch December 12, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Collect all logs for e2e tests
3 participants