e2e: add parallel VM installation #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldevulder
force-pushed
the
e2e-add-parallel-vm-installation
branch
3 times, most recently
from
d57174e
to
33ad3a0
Compare
ldevulder
force-pushed
the
e2e-add-parallel-vm-installation
branch
2 times, most recently
from
27eb674
to
1ca5f49
Compare
ldevulder
force-pushed
the
e2e-add-parallel-vm-installation
branch
21 times, most recently
from
28f20b4
to
9d3e551
Compare
ldevulder
force-pushed
the
e2e-add-parallel-vm-installation
branch
8 times, most recently
from
9bd1dd2
to
3106b0a
Compare
As the docs have been moved in his own repository. Signed-off-by: Loic Devulder <ldevulder@suse.com>
This is needed to be able to install multiple nodes in parallel. Signed-off-by: Loic Devulder <ldevulder@suse.com>
Allows node bootstrapping to be done in parallel for worker pool. Signed-off-by: Loic Devulder <ldevulder@suse.com>
Store each VM disk image in a dedicated storage pool to avoid locking during parallel bootstrapping. Signed-off-by: Loic Devulder <ldevulder@suse.com>
Conditions are not exactly the same when multiple nodes are in Waiting state. Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Needed because the parallel bootstrapping imposes more operations in parallel and so the cluster can take more time to deployed. Signed-off-by: Loic Devulder <ldevulder@suse.com>
This is to avoid sporadic context issues with goroutine. Better to check for the same string on all nodes instead of the hostname. And in fact the hostname set on the node is not very important at this point. Signed-off-by: Loic Devulder <ldevulder@suse.com>
Change to the correct variable name. Signed-off-by: Loic Devulder <ldevulder@suse.com>
Sounds logical, but was not done on RKE2. Signed-off-by: Loic Devulder <ldevulder@suse.com>
As the bootstrapping logs are now exported, no needs to have them in the regular CI process. This will reduce the logs on GitHub and also make them more readable. Signed-off-by: Loic Devulder <ldevulder@suse.com>
As this is not needed, only worker role should be set. Signed-off-by: Loic Devulder <ldevulder@suse.com>
ldevulder
force-pushed
the
e2e-add-parallel-vm-installation
branch
from
3106b0a
to
238964d
Compare
frelon
reviewed
Jan 19, 2023
As it is broken because the `elemental-node-image` used is too old and not compatible with newer Elemental version. This will be re-worked and re-added in a near future. Signed-off-by: Loic Devulder <ldevulder@suse.com>
ldevulder
force-pushed
the
e2e-add-parallel-vm-installation
branch
from
238964d
to
0f0b11f
Compare
frelon
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #148.
Verification run:
NOTE: I also tested with 20 nodes but it fails all the time and also with 10 nodes on K3s. But as the CI version (with 5 nodes) works well I think that we can merge this PR and I will check why more nodes are failing and fix this in another PR.